Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM #316

Merged
merged 10 commits into from
Feb 15, 2024
Merged

ESM #316

merged 10 commits into from
Feb 15, 2024

Conversation

tpluscode
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: 2d1ac5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
alcaeus Major
alcaeus-model Major
alcaeus-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (1cdc2a9) 92.70% compared to head (2d1ac5d) 95.80%.
Report is 1 commits behind head on master.

Files Patch % Lines
packages/alcaeus/helpers/fetchToStream.ts 55.38% 28 Missing and 1 partial ⚠️
packages/alcaeus/alcaeus.ts 93.88% 14 Missing ⚠️
packages/model/CoreMixins/HydraResource.ts 93.78% 11 Missing ⚠️
packages/alcaeus/ResponseWrapper.ts 90.62% 9 Missing ⚠️
packages/model/CoreMixins/OperationFinder.ts 95.92% 8 Missing and 1 partial ⚠️
packages/model/Mixins/ApiDocumentation.ts 91.89% 3 Missing ⚠️
packages/model/Operation.ts 91.66% 3 Missing ⚠️
packages/model/Mixins/Class.ts 97.64% 2 Missing ⚠️
packages/alcaeus/mediaType.ts 0.00% 1 Missing ⚠️
packages/model/Mixins/Operation.ts 97.14% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   92.70%   95.80%   +3.09%     
==========================================
  Files          35       40       +5     
  Lines         631     2001    +1370     
  Branches      131      211      +80     
==========================================
+ Hits          585     1917    +1332     
- Misses         46       82      +36     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode merged commit c4606c6 into master Feb 15, 2024
8 checks passed
@tpluscode tpluscode deleted the esm branch February 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant